----- Original Message ----- > From: "Tim Flink" <tfl...@redhat.com> > To: qa-devel@lists.fedoraproject.org > Sent: Friday, June 12, 2015 8:49:53 AM > Subject: Coding Style > > Back to everyone's favorite topic - coding style and enforcement of > that style. > > I'm not picking on Josef here - I'm sure I've submitted code recently > with lint errors, this was just the review I was looking at which > triggered the idea: > > https://phab.qadevel.cloud.fedoraproject.org/D389 > > Since the last discussion about coding style ended in a long discussion > about PEP8, the bits we may not like about the standard and the > exceptions that we'd want, I'm proposing that we use strict PEP8 with > almost no exceptions. I'm not saying that that PEP8 is perfect or > that there aren't parts of it I would like to tweak but > - it's a well known standard, easy for non-regular contributors to > understand and use > - style checking tools tend to use PEP8 out of the box > - if we don't allow exceptions, there will be less time spent on > discussing details instead of being productive :) > > To be more specific, I am proposing the following: > - all QA devel projects be have flake8 as the linter in arc config > - no code be accepted with lint errors unless there is absolutely no > other way to get around it > - until we get our entire codebase PEP8 compliant, "if you touch a > file, fix the lint errors even if those errors are not part of what > you're changing" > > Any strong objections to starting this? Any strong objections should > have an alternative proposal and a justification why that proposal is > worth deviating from a well known and established standard. >
By saying we should use strict PEP8, does that mean you want to get rid of the linter settings we have in .arclint or leave it there? Other than that, I have no objections. I am all for being strict and consistent and avoiding discussing details at the expense of productivity. Thanks, Martin _______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/qa-devel
