On 06/13/2015 12:33 AM, Tim Flink wrote: > On Fri, 12 Jun 2015 09:21:38 -0400 (EDT) > Kamil Paral <kpa...@redhat.com> wrote: > >>>> Back to everyone's favorite topic - coding style and enforcement >>>> of that style. >> >> And I thought we were doing so great by leaving it behind... >> >>>> >>>> I'm not picking on Josef here - I'm sure I've submitted code >>>> recently with lint errors, this was just the review I was looking >>>> at which triggered the idea: >>>> >>>> https://phab.qadevel.cloud.fedoraproject.org/D389 >> >> As I already mentioned in the review, the way how Phab displays lint >> errors is a problem in this particular case - the diff is hard to >> read. That is something I'd like to avoid in the future. > > Getting rid of most lint errors/warnings/advice would be one way of > doing that :)
Folks can also configure their local clone to run the flake8 checks before allowing a commit: https://flake8.readthedocs.org/en/latest/vcs.html Code contributions to open source projects are "free as in puppy" rather than "free as in beer", and core contributor time is almost always the limiting factor on development progress, so it's reasonable to impose certain minimal expectations on potential contributors. Cheers, Nick. -- Nick Coghlan Red Hat PnT Operations DevOps Enablement, Brisbane Software Development Workflow Designer & Process Architect _______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/qa-devel
