> -----Original Message----- > From: Cédric Le Goater <[email protected]> > Sent: Monday, January 26, 2026 4:45 PM > To: Kane Chen <[email protected]>; Peter Maydell > <[email protected]>; Steven Lee <[email protected]>; Troy > Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew > Jeffery <[email protected]>; Joel Stanley <[email protected]>; > open list:ASPEED BMCs <[email protected]>; open list:All patches CC > here <[email protected]> > Cc: Troy Lee <[email protected]> > Subject: Re: [PATCH v5 14/22] hw/arm/aspeed: Introduce 'bus-label' property > for AST1700 SoC > > On 1/20/26 06:18, Kane Chen via wrote: > > From: Kane-Chen-AS <[email protected]> > > > > The AST2700 SoC can be integrated with multiple AST1700 IO expanders. > > Without unique identifiers, the I2C bus object names for the primary > > BMC SoC and multiple expander chips may collide in the QOM (QEMU > > Object Model) tree. > > > > To resolve this, introduce a bus-label property to the AST1700 SoC. > > This allows the parent SoC (AST2700) to assign a unique prefix (e.g., > > "ioexp0", "ioexp1") to each AST1700 instance. These labels ensure that > > the bus naming hierarchy remains distinct and traceable across > > different expanders. > > > > Signed-off-by: Kane-Chen-AS <[email protected]> > > --- > > include/hw/arm/aspeed_ast1700.h | 1 + > > hw/arm/aspeed_ast1700.c | 1 + > > hw/arm/aspeed_ast27x0.c | 3 +++ > > 3 files changed, 5 insertions(+) > I don't think this change is needed. > > Setting the AspeedI2CState "bus-label" property in aspeed_ast1700_realize() > should be sufficient. > > Thanks, > > C.
Hi Cédric, Understood. I will drop this change in the next patch series. Thanks. Best Regards, Kane
