On 9/24/26 4:12 PM, Matthew Rosato wrote:
> On 9/24/26 3:48 PM, Zhuoying Cai wrote:
>> Enable network booting via virtio-net-pci by implementing PCI transport
>> support for virtio-net.
>>
>> This patch also extends endianness handling for virtio PCI ring operations in
>> little-endian to ensure correct behavior on s390x.
>>
>> Signed-off-by: Zhuoying Cai <[email protected]>
>> Reviewed-by: Jared Rossi <[email protected]>
>> Reviewed-by: Matthew Rosato <[email protected]>
>
> Looks like rebase errors with this patch, see below...
>
Thanks for catching this. I’ll fix the rebase errors.
>
>> /* Move index to next entry */
>> diff --git a/pc-bios/s390-ccw/virtio-pci.c b/pc-bios/s390-ccw/virtio-pci.c
>> index 277c3ea68d..7fb987099d 100644
>> --- a/pc-bios/s390-ccw/virtio-pci.c
>> +++ b/pc-bios/s390-ccw/virtio-pci.c
>> @@ -55,6 +55,9 @@ void virtio_pci_id2type(VDev *vdev, uint16_t device_id)
>> case 0x1048:
>> case 0x1004:
>> vdev->dev_type = VIRTIO_ID_SCSI;
>
> missing break?
>
>> + case 0x1041:
>> + case 0x1000:
>> + vdev->dev_type = VIRTIO_ID_NET;
>> break;
>
> [...]
>
>
>> @@ -413,6 +428,9 @@ int virtio_pci_setup(VDev *vdev)
>> vdev->nr_vqs = 3;
>> vdev->cmd_vr_idx = 2;
>> virtio_pci_get_scsi_config();
>
> missing break?
>
>> + case VIRTIO_ID_NET:
>> + vdev->nr_vqs = 2;
>> + virtio_pci_get_net_config();
>> break;
>> default:
>> puts("Unsupported virtio device");
>
