On 9/24/26 3:48 PM, Zhuoying Cai wrote: > Add test coverage for virtio-net-pci network booting on s390x by > including it in the PXE test suite. The test verifies that PXE > network booting works correctly with virtio-net-pci devices. > > Signed-off-by: Zhuoying Cai <[email protected]> > Tested-by: Joshua Daley <[email protected]>
It's still kind of confusing, but this is a little better. Not sure if we will need to come up with a better way of identifying the existence of a feature for s390x bios in the future, but for now: Reviewed-by: Matthew Rosato <[email protected]> > --- > tests/qtest/pxe-test.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c > index 61ad572bb7..b12de2bedc 100644 > --- a/tests/qtest/pxe-test.c > +++ b/tests/qtest/pxe-test.c > @@ -126,9 +126,20 @@ static bool s390_bios_has_net_ccw(void) > return s390_bios_has_string("Network boot starting..."); > } > > +static bool s390_bios_has_net_pci(void) > +{ > + /* > + * Check for a string unique to virtio-net-pci boot support in the bios > + * to determine if the binary was built with support for this device. > + */ > + return s390_bios_has_string("Setup failed for virtio-net-pci"); > +} > + > static testdef_t s390x_tests[] = { > { "s390-ccw-virtio", "virtio-net-ccw", > .boot_dev_support = s390_bios_has_net_ccw }, > + { "s390-ccw-virtio", "virtio-net-pci", > + .boot_dev_support = s390_bios_has_net_pci }, > { NULL }, > }; >
