On 9/24/26 4:25 PM, Matthew Rosato wrote:
>
>> +
>> +static bool s390_bios_has_net_ccw(void)
>> +{
>
> Since you'll need to respin anyway...
>
> Sorry, I think there was some confusion about what I asked for here.
>
> AFAIU checking for this string is going to unconditionally work as long
> as we enter netboot code, before we even decide if -ccw- or -pci support
> is actually available. That's why you don't use this test for
> virtio-net-pci.
>
> Your old comment block said virtio-net-ccw support has always been there
> (that's not strictly true)
>
> So rather than removing the comment block, just reword it to explain
> that the test just assumes virtio-net-ccw support is always available
> and only checks that netboot started, it doesn't try to verify ccw support.
Quick clarification: I meant 'only checks that netboot code exists' --
since we are just looking for the existence of the string, not that it's
being output somewhere.
You're assuming if netboot support exists then it always supports -ccw
and maybe that's the right way to word it. If that assumption ever were
to change in the future then we'd need to revisit the testcase.
>
>> + return s390_bios_has_string("Network boot starting...");
>> +}
>> +
>> static testdef_t s390x_tests[] = {
>> - { "s390-ccw-virtio", "virtio-net-ccw" },
>> + { "s390-ccw-virtio", "virtio-net-ccw",
>> + .boot_dev_support = s390_bios_has_net_ccw },
>> { NULL },
>> };
