On 9/24/26 5:15 PM, Matthew Rosato wrote:
On 9/24/26 3:48 PM, Zhuoying Cai wrote:
Add test coverage for virtio-net-pci network booting on s390x by
including it in the PXE test suite. The test verifies that PXE
network booting works correctly with virtio-net-pci devices.
Signed-off-by: Zhuoying Cai <[email protected]>
Tested-by: Joshua Daley <[email protected]>
It's still kind of confusing, but this is a little better.
Not sure if we will need to come up with a better way of identifying the
existence of a feature for s390x bios in the future, but for now:
Reviewed-by: Matthew Rosato <[email protected]>
Probably the normal console messages just need to be updated. Currently
it prints a message like "using virtio-blk" or "netboot started" and that
was fine when only CCW was supported for those devices, but now that there
are a lot more device/bus combinations I think we need to be more verbose.
That would make feature checks easier and also provide better diagnostic
output in general.
In the meantime, this particular output could be clarified by simply using
a substring of the same string literal:
return s390_bios_has_string("virtio-net-pci");
Will result in:
# "virtio-net-pci" found in bios
(or not found) which is much more logical to me. I wouldn't respin the
series just for that though since the test itself does work as intended.
Reviewed-by: Jared Rossi <[email protected]>
