On Tue, 2026-10-20 at 21:39 +0200, Philippe Mathieu-Daudé wrote: > On 20/10/26 21:30, Philippe Mathieu-Daudé wrote: > > Hi, > > > > On 20/10/26 16:55, Stian Halseth wrote: > > > Implement the eight AES round instructions by using QEMU's shared > > > crypto/aes-round.h, gated behind the crypto CPU feature: > > > - AES_EROUND01/23 and last variants > > > - AES_DROUND01/23 and last variants > > > > > > Based on OSA (Oracle SPARC Architecture) 2011, section 7.3: > > > AES Cryptographic Operations (4 operand) > > > > > > Signed-off-by: Stian Halseth <[email protected]> > > > --- > > > target/sparc/crypto_helper.c | 85 > > > ++++++++++++++++++++++++++++++++++++ > > > target/sparc/helper.h | 8 ++++ > > > target/sparc/insns.decode | 9 ++++ > > > target/sparc/meson.build | 2 +- > > > target/sparc/translate.c | 16 +++++++ > > > 5 files changed, 119 insertions(+), 1 deletion(-) > > > create mode 100644 target/sparc/crypto_helper.c > > > > Could we add tests (in tests/tcg, following commit 57b484e2d23 > > "target/riscv: fix RV32 fixed counter accesses" which uses the > > debian-all-test-cross image -- where gcc-sparc64-linux-gnu is > > available)? Actually we could put them in tests/tcg/multiarch/ > > as generic AES tests. > > (Can be done later, on top, not a blocking comment). >
Noted, then I will make a v2 based on initial feedback first, then test as a follow up. /Stian
signature.asc
Description: This is a digitally signed message part
