On 16.07.2013 12:55, Paolo Bonzini wrote:
Il 15/07/2013 12:49, Peter Lieven ha scritto:
this adds the proposed solution to add a generic mechanism to zeroize
a target in qemu-img if it has discard_zeroes but has_zero_init is 0.
Peter Lieven (4):
block: add discard_zeroes and max_unmap to BlockDriverInfo
iscsi: add .bdrv_get_info
block/raw: add .bdrv_get_info
qemu-img: conditionally discard target on convert
block/iscsi.c | 19 +++++++++++++++--
block/raw.c | 6 ++++++
include/block/block.h | 5 +++++
qemu-img.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++-
4 files changed, 83 insertions(+), 3 deletions(-)
Looks good. Perhaps, as a followup, you can use max_unmap (which I'd
rename to max_discard) in bdrv_co_discard to support splitting the
request. You could also export the discard alignment in BlockDriverInfo.
I already did this in my previous series for iscsi. But I can also add a follow
up if in the future another driver specifies max_discard. I will drop it from
iscsi again then.
Before this patch here is merged, we need the other series "[PATCHv3 00/10]
iscsi/qemu-img/block-migration enhancements"
otherwise patch 2/4 will not apply. Maybe you can put it together again or I
will do a v4 with all patches
together.
Thanks,
Peter