Il 16/07/2013 13:18, Peter Lieven ha scritto: >> Looks good. Perhaps, as a followup, you can use max_unmap (which I'd >> rename to max_discard) in bdrv_co_discard to support splitting the >> request. You could also export the discard alignment in BlockDriverInfo. > I already did this in my previous series for iscsi. > But I can also add a follow > up if in the future another driver specifies max_discard. I will drop it > from iscsi again then.
In general, I prefer to have things in the block layer if there is a chance of them becoming generic. I guess in this case the chance is relatively small. On the other hand, if you add any smartness such as handling alignment (see http://lkml.org/lkml/2012/7/5/342) please do take the occasion to move it out of block/iscsi.c. > Before this patch here is merged, we need the other series "[PATCHv3 > 00/10] iscsi/qemu-img/block-migration enhancements" > otherwise patch 2/4 will not apply. Maybe you can put it together again > or I will do a v4 with all patches together. Perhaps. Both might also conflict with my get_block_status patches. I'm going to send an updated version today. Ugh, it's already 1:30 PM. :( Paolo
