On 08/22/10 22:15, Avi Kivity wrote: > On 08/19/2010 09:29 PM, Blue Swirl wrote: >> >>> Just to be sure I follow, are you suggesting we relax all of the bracing >>> rule, or just the part about braces around single line statements? I'd >>> be happy to write up a patch for the latter. >> I'd rather not relax the rules but find a solution so that the rules >> work. > > I happen to like the single line braces rule. That is, I don't like how > the code looks (I dislike punctuation generally), but I like the > consistency and I like how patches that add or remove a line are easy to > read. > > My preference would be: new code has to adhere to the new style.
Agreed, once we pick something, make the new stuff stick to that. The main issue is when you make mods to a file that is using a different style. It's not ideal that you add one line of the new style and the rest is the old way. > Perhaps we can have a bot subscribed to the list issue auto-reviews if > things are incorrect. That might work. Cheers, Jes
