Am 02.01.2011 um 00:46 schrieb Peter Maydell:
On 17 December 2010 15:56, Peter Maydell <peter.mayd...@linaro.org>
wrote:
The softfloat functions float*_is_nan() were badly misnamed,
because they return true only for quiet NaNs, not for all NaNs.
Rename them to float*_is_quiet_nan() to more accurately reflect
what they do.
This change was produced by:
perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
(with the results manually checked.)
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Nathan Froyd <froy...@codesourcery.com>
Acked-by: Edgar E. Iglesias <edgar.igles...@gmail.com>
Ping? This patch got no further comments (although it provoked
a long thread on a completely unrelated topic), it's been
reviewed and it still applies to master currently. I think it's
an uncontroversially good idea (~80% of current uses of the
functions are actually buggy because the people who wrote
them were misled by the function name!).
Can it be applied please?
No objections from my side. While I have not yet tested it, the fpu/
changes only have *_is_* functions in the patch context and introduce
no new type hickups as far as I could see.
Andreas
