On 18 June 2018 at 17:17, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > There is no obvious reason to have a loop counter. This limits from > reading several megabytes large buffers in one go, since socket > read/write usually have a limit. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > chardev/char-fe.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)
> diff --git a/chardev/char-fe.c b/chardev/char-fe.c > index b1f228e8b5..f158f158f8 100644 > --- a/chardev/char-fe.c > +++ b/chardev/char-fe.c > @@ -56,7 +56,7 @@ int qemu_chr_fe_write_all(CharBackend *be, const uint8_t > *buf, int len) > int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len) > { > Chardev *s = be->chr; > - int offset = 0, counter = 10; > + int offset = 0; > int res; Subject says "qemu_char_fe_write_all()" but patch is changing qemu_chr_fe_read_all()... thanks -- PMM