Eduardo Habkost <ehabk...@redhat.com> writes: > On Thu, May 23, 2019 at 06:14:18PM +0200, Markus Armbruster wrote: >> It's nice when QAPI schema modules clearly belong to a single subsystem >> in addition to "QAPI Schema". misc.json doesn't, and it's grown fat: >> 3000+ lines. Let's move out some stuff. Here are a few candidates: >> >> * Dump (Marc-André) >> >> dump-guest-memory, query-dump, DUMP_COMPLETED, >> query-dump-guest-memory-capability >> >> ~200 lines. >> >> * Machine core (Eduardo, Marcel) >> >> query-machines, query-current-machine, >> >> ~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of >> view. Might be worthwhile from a "let's make get_maintainers.pl >> work". >> >> * CPUs (Paolo, Richard) >> >> query-cpus, query-cpus-fast >> >> ~300 lines. The commands are implemented in cpus.c, which MAINTAINERS >> covers both under "Main loop" and under "Guest CPU cores (TCG) / >> Overall". Neither feels right to me for these QMP commands. > > Should it include query-cpu-* (currently on target.json), > and query-hotpluggable-cpus?
Interesting question. We might need both cpu.json and cpu-target.json, to keep target-independent and target-dependent separated. >> * NUMA (Eduardo) >> >> query-memdev, set-numa-node >> >> ~200 lines. >> >> Opinions? >> >> Additional candidates? > > QOM: qom-list, qom-get, qom-set, qom-list-properties, object-add > object-del. Also qom-list-types. ~230 lines. As long as we don't have an active QOM maintainer[*], the benefit is low. [*] We need one. I'm not volunteering.