This one slipped through the cracks of a notoriously understaffed pull request review team. Sorry for that. I just reopened it, since it looks reasonable. If you run into this again, please ask what can be done to continue with the pull request, a comment will show your interest, likely attract reviewers - and also snooze the stale bot.
Matthias On Tue, Dec 22, 2020 at 3:59 PM Ian Turton <ijtur...@gmail.com> wrote: > Actually it was the PR itself that was closed - > https://github.com/qgis/QGIS/pull/39231 > > Ian > > On Tue, 22 Dec 2020 at 14:54, Matthias Kuhn <matth...@opengis.ch> wrote: > >> Hi Ian, >> >> Can you share a link to this issue? >> >> Thanks >> Matthias >> >> On Tue, Dec 22, 2020 at 3:51 PM Ian Turton <ijtur...@gmail.com> wrote: >> >>> That's odd to hear as I had one marked stale that had a PR attached >>> >>> Ian >>> >>> On Tue, 22 Dec 2020 at 10:03, Matthias Kuhn <matth...@opengis.ch> wrote: >>> >>>> Hi Richard, >>>> >>>> Sorry if it was a bit a rough start! >>>> The stale bot specifically picks only issues which are left with the >>>> "feedback" label. >>>> This was the case with these two issues. I notice Giovanni already >>>> fixed this. >>>> >>>> The assumption is that the veggies don't have open questions on them >>>> and this way we can filter the weed. Does that sound reasonable to you? >>>> >>>> Best regards >>>> Matthias >>>> >>>> On Tue, Dec 22, 2020 at 9:38 AM Richard Duivenvoorde < >>>> rdmaili...@duif.net> wrote: >>>> >>>>> I received some "this issue will be closed because of lack of >>>>> feedback", >>>>> but I think current 'stale bot implementation' is a little rude on the >>>>> edges. >>>>> >>>>> (did I miss some discussion about this here?) >>>>> >>>>> I received some "this issue will be closed because of lack of >>>>> feedback", only because I commented on them. But some are just plain >>>>> valid: >>>>> >>>>> As an example: >>>>> https://github.com/qgis/QGIS/issues/39107#issuecomment-749298135 >>>>> that is just a valid use-case (or maybe feature request?) >>>>> >>>>> This one: >>>>> https://github.com/qgis/QGIS/issues/37984 >>>>> is just valid (I even installed Oracle to check this...) >>>>> >>>>> This one: also valid and still needed: >>>>> https://github.com/qgis/QGIS/issues/37956 >>>>> >>>>> Weeding the issues is not nice, so removing non-valid, old or non >>>>> responding is fine, but now I think the bot is pulling the veggies instead >>>>> of the weed :-) >>>>> >>>>> Regards, >>>>> >>>>> Richard Duivenvoorde >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> QGIS-Developer mailing list >>>>> QGIS-Developer@lists.osgeo.org >>>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>> >>>> _______________________________________________ >>>> QGIS-Developer mailing list >>>> QGIS-Developer@lists.osgeo.org >>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer >>>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer >>>> >>> >>> >>> -- >>> Ian Turton >>> >> > > -- > Ian Turton >
_______________________________________________ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer