Steve Kemp wrote: > On Mon Jul 28, 2008 at 17:24:59 -0400, Brian Szymanski wrote: > > >> What real errors would your diffs catch? The one case you showed >> involved a false positive. >> > > With the assumption that you run "make test" prior to commiting > then it would catch a genuine syntax error. Such as the > following which I introduced into uribl: > > my %strict_twolevel_cctlds = ( > 'ac' => 1, > + 'ae' => 1 > - 'ae' => 1, > 'uk' => 1, > > > (i.e. I removed a trailing comma in a hasty edit, and didn't > realize until I committed the plugin to my master site and updated > all my MX machines.) > > >> Why not let the test script use Qpsmtpd::Constants and anything else all >> plugins use, instead of adding a line to each plugin in the universe >> (many if not most of which are third party and out of control of svn >> anyway)? >> > > That is of course the simpler solution. > Then let's make that diff instead - remove all the "use Qpsmtpd::Constants" in plugins, and add your test harness?
Cheers, Brian Szymanski
