> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863> > > > > I'm no UI expert, but this entire new block seems to be doing repo > > stuff that already is on the UI. Can you explain the gist here?
We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts . > On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. Made the required change in next diff. > On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 1192 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line1192> > > > > ftp? I think it's fine to be only http or https. Made the required change in next diff. - Sonia ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ----------------------------------------------------------- On Dec. 22, 2017, 4:41 a.m., Sonia Garudi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 4:41 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > ------- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step3_controller.js 29393e3 > ambari-web/app/styles/wizard.less 7d425d9 > ambari-web/app/templates/wizard/step3.hbs e00012c > ambari-web/app/utils/ajax/ajax.js 3f85dfdc > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/2/ > > > Testing > ------- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
