> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863> > > > > I'm no UI expert, but this entire new block seems to be doing repo > > stuff that already is on the UI. Can you explain the gist here? > > Sonia Garudi wrote: > We need each host's os type which is not available on the UI. This > function makes an API call which gets information of all the bootstrapped > hosts . > > Nate Cole wrote: > I see. We should probably have that returned as part of host > registration and read it from there instead of making another call. Is that > possible in this patch? > > Sonia Garudi wrote: > The os types of the bootstrapped hosts can be obtained in the > registration success callback(isHostsRegisteredSuccessCallback) which would > eliminate the above API call. This would involve editing the > 'wizard.step3.is_hosts_registered' API call in ajax.js to include the > 'Hosts/os_type' field. > Please let me know your suggestions. > > Nate Cole wrote: > That sounds reasonable instead of making another call. Can we make that > an error/failure case after registration that we don't have a JAVA_HOME > matching the type?
Do you want us to fail the Host Registration if java home is not found for host os_type? We were planning to just show a message on the host check warnings popup that Host does not have proper Java Home set of its Os type and default java home will be used. This assumption is because during normal(existing) flow Amabari show warning for incorrect Java Home and does not fail registration. - Yussuf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ----------------------------------------------------------- On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 12:07 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > ------- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step3_controller.js 55f4323 > ambari-web/app/styles/wizard.less 4e680ca > ambari-web/app/templates/wizard/step3.hbs ff436a8 > ambari-web/app/utils/ajax/ajax.js 483be5e > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/4/ > > > Testing > ------- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
