> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. > > Sonia Garudi wrote: > Made the required change in next diff. > > Nate Cole wrote: > Ok, please resolve review issues as they are fixed in diffs with "Fixed"
I made the change to get the stackId based on repositoryVersion instead of displayName. However, the repositoryVersion is set to '2.6.2.0' irrespective of the actual version of HDP installed(not sure if its a bug). I was unable to retrieve the proper installed version of HDP on the UI using any API call. Please let me know your suggestions. - Sonia ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ----------------------------------------------------------- On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 12:07 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > ------- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step3_controller.js 55f4323 > ambari-web/app/styles/wizard.less 4e680ca > ambari-web/app/templates/wizard/step3.hbs ff436a8 > ambari-web/app/utils/ajax/ajax.js 483be5e > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/4/ > > > Testing > ------- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
