jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r329787483
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancer.java
##########
@@ -110,9 +111,9 @@ protected ResourceControllerDataProvider
setupClusterDataCache() throws IOExcept
}
@Test
- public void testRebalance() throws IOException, HelixRebalanceException {
+ public void testRebalance() throws IOException, HelixRebalanceException,
JMException {
_metadataStore.clearMetadataStore();
- WagedRebalancer rebalancer = new WagedRebalancer(_metadataStore,
_algorithm);
+ WagedRebalancer rebalancer = new WagedRebalancer(_metadataStore,
_algorithm, null);
Review comment:
Not sure about all the usage, but if all test code is passing null, we can
just remove this parameter from this constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
