Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Restore checking inflight in retry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc@376 PS1, Line 376: // If the query's not yet inflight, skip it. It should be unregistered later. > Should this be Oh, yes it should. I went through several iterations of trying different things and messed it up at the end. But this is part of my concern that "I can't get this section to matter" as well. -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2023 18:15:28 +0000 Gerrit-HasComments: Yes
