Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc@376 PS1, Line 376: // that the query is not marked inflight yet; what happens in that case is: > Oh, yes it should. I went through several iterations of trying different th Done http://gerrit.cloudera.org:8080/#/c/20799/2/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/20799/2/tests/custom_cluster/test_query_retries.py@777 PS2, Line 777: 'debug_action': 'SET_QUERY_INFLIGHT:SLEEP@1000'}) > Ok, after fixing the check the coordinator crashes due to Done -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2023 20:34:06 +0000 Gerrit-HasComments: Yes
