Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc@375 PS3, Line 375: It's possible (but rare) : // that the query is not marked inflight yet; what happens in that case is: > I'm not sure we can make it more deterministic; that has a lot of potential Make sense. IMPALA-12493 did this change: - RETURN_VOID_IF_ERROR(query_handle->Finalize(true, nullptr)); + DCHECK(query_handle->is_inflight()); + query_handle->Finalize(nullptr); parent_server_->CloseClientRequestState(query_handle); parent_server_->MarkSessionInactive(session); Finalize() changed to void, so it is not returning ERROR from Cancel() anymore. CloseClientRequestState() look safe to call in any case, (inflight_queries.erase will just turn no op). MarkSessionInactive() is also valid to call since the refcount decrease match refcount increase from MarkSessionActive() in line 266. This looks OK. http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc@380 PS3, Line 380: 1. > nit: 3 Will +1 once this nit addressed. -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2023 21:58:18 +0000 Gerrit-HasComments: Yes
