Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Restore checking inflight in retry ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20799/2/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/20799/2/tests/custom_cluster/test_query_retries.py@777 PS2, Line 777: 'debug_action': 'SET_QUERY_INFLIGHT:SLEEP@1000'}) Ok, after fixing the check the coordinator crashes due to client-request-state.cc:179] Check failed: wait_thread_.get() == __null BlockOnWait() needs to be called! Which makes sense to me, it hasn't successfully closed. I don't see a reason to skip closing the request state if it hasn't been set to inflight yet. The only consequence I can identify is that the original query might be added to inflight_queries, then not removed until the session is closed. But once the overall query is closed, both the original and retrying query move to completed queries. And despite not being removed from inflight_queries, the query is removed from query_driver_map_ so it's not observable in the web UI. The only consequence a user might observe is a failure trying to UnregisterQuery when the session is closed. -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2023 20:20:22 +0000 Gerrit-HasComments: Yes
