Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) This patch looks good to me. I just have 1 question. http://gerrit.cloudera.org:8080/#/c/20707/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20707/3//COMMIT_MSG@15 PS3, Line 15: Callers can catch the exception and convert it : into MetastoreNotificationFetchException which won't fail the : event-processor. nit: There are several places where getMetastoreClient() is called. This patch, however, only catch MetastoreClientInstantiationException in 2 out of 6 call site at MetastoreEventProcessor.java. Why not catch it in getNextMetastoreEventsInBatches() as well? >From the other comment thread, I assume it just a matter of priority now and >other call site should be investigated if they are retriable as well? If that >is true, do you mind mentioning in commit message why only catch >MetastoreClientInstantiationException in this two place for now? -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2023 05:46:26 +0000 Gerrit-HasComments: Yes
