[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1122 PS3, Line 1122: event.processIfEnabled(); > Yeah, that's a concern. Our goal is to survive in intermittent HMS errors. How about catching MetastoreClientInstantiationException in MetastoreEventsProcessor#processEvents() and logging it? We will be able to avoid updating eventProcessorStatus_ to EventProcessorStatus.ERROR. Anyway, in the subsequent scheduled runs of processEvents() when hms becomes available again, it starts to process from the last failed event. -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 16:34:16 +0000 Gerrit-HasComments: Yes
