Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1122 PS3, Line 1122: event.processIfEnabled(); > How about catching MetastoreClientInstantiationException in MetastoreEvents I think it depends on where the failure happens. If the table metadata is half updated and become corrupt, the retry might fail. That's also the reason we throw MetastoreNotificationNeedsInvalidateException in many places. I think we are conservative. There should be some failure points that are retriable. It needs more time to go through all event code paths and requires a larger change. As a hot fix, maybe the current patch + bumping HMS client retry configs is simpler. -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 01:15:34 +0000 Gerrit-HasComments: Yes
