[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1122 PS3, Line 1122: event.processIfEnabled(); catalog_.getMetaStoreClient() throws MetastoreClientInstantiationException now and it is an unchecked exception. Certain events like addpartition, alterpartition, altertable, committxn etc make calls to HMS during the respective event processing(i.e., they do getMetaStoreClient() in the event.process() call). If getMetaStoreClient() the exception during that time, MetastoreClientInstantiationException is not caught and it propagted all the way till MetastoreEventsProcessor#processEvents() and we update eventProcessorStatus_ with EventProcessorStatus.ERROR. -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 16 Nov 2023 11:18:18 +0000 Gerrit-HasComments: Yes
