Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 )
Change subject: IMPALA-12744: Support for regr_count() aggregate function ...................................................................... Patch Set 1: (11 comments) Thanks Pranav! http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@7 PS1, Line 7: aggregate If it can be used as both an aggregate and an analytical function, having "aggregate" in the title is misleading. http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: as Nit: "as an" http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: regr_count Nit: "The regr_count() functin..." http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: and Nit: "and an" http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10 PS1, Line 10: functions Nit: function (singular). http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10 PS1, Line 10: are Nit: is. http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc@307 PS1, Line 307: ctx We don't use 'ctx' and in the above two functions this variable was unnamed. Either having a name or not is ok, but it should be consistent. See also L313. http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc@315 PS1, Line 315: / Remove doesn't need to explicitly check the number of calls to Update() or Remove() : // because Finalize() returns NULL if count is 0. In other words, it's not needed to : // check if num_removes() >= num_updates() as it's accounted for in Finalize(). Is this different here than in the non-timestamp version, i.e. on L300? http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h File be/src/exprs/aggregate-functions.h: http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h@74 PS1, Line 74: ctx We don't use 'ctx' and in the above two functions this variable was unnamed. Either having a name or not is ok, but it should be consistent. See also L76. http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test File testdata/workloads/functional-query/queries/QueryTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2713 PS1, Line 2713: null This doesn't return null, it returns 1. http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2802 PS1, Line 2802: rand() Is there a specific reason for using rand() and not a simple constant? -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jan 2024 13:19:03 +0000 Gerrit-HasComments: Yes
