Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 )
Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: as "as an" http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: and "and an" http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: regr_count() We should have "The regr_count() function". http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc@307 PS2, Line 307: ctx We don't use 'ctx' and in the above two functions this variable was unnamed. Either having a name or not is ok, but it should be consistent with the above functions. See also L313. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 08:31:47 +0000 Gerrit-HasComments: Yes
