pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 )
Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function ...................................................................... Patch Set 2: (10 comments) > Uploaded patch set 2. http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@7 PS1, Line 7: aggregate > If it can be used as both an aggregate and an analytical function, having " Done http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: regr_count > Nit: "The regr_count() functin..." Done http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: as > Nit: "as an" Done http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9 PS1, Line 9: and > Nit: "and an" Done http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10 PS1, Line 10: function > Nit: function (singular). Done http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10 PS1, Line 10: s c > Nit: is. Done http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc@315 PS1, Line 315: CHECK(!dst->is_null); : if (!src1.is_null && !src2.is_null) { : --dst->val; > Is this different here than in the non-timestamp version, i.e. on L300? Removed http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h File be/src/exprs/aggregate-functions.h: http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h@74 PS1, Line 74: > We don't use 'ctx' and in the above two functions this variable was unnamed Done http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test File testdata/workloads/functional-query/queries/QueryTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2713 PS1, Line 2713: 1 in > This doesn't return null, it returns 1. Ack http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2802 PS1, Line 2802: rand() > Is there a specific reason for using rand() and not a simple constant? No, not really, it was brought up in corr() patch I think and since then it's kept in the same way to maintain uniformity. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jan 2024 07:01:18 +0000 Gerrit-HasComments: Yes
