Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 )
Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function ...................................................................... Patch Set 3: (1 comment) Looks good to me, just one small issue. http://gerrit.cloudera.org:8080/#/c/20936/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/3/be/src/exprs/aggregate-functions-ir.cc@304 PS3, Line 304: DCHECK_GE(dst->val, 0); I think this line of code should also be inside the if block above. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Tue, 06 Feb 2024 06:59:18 +0000 Gerrit-HasComments: Yes