Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/21426/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21426/1//COMMIT_MSG@9 PS1, Line 9: This change will print timestamp of exception occurring during executing a query nit: we prefer 72 characters as the max width in commit message http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@763 PS1, Line 763: print("Warning: close session RPC failed: {0}, {1}".format(str(e), type(e))) This also needs a timestamp. http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@1154 PS1, Line 1154: print('Caught exception {0}, type={1} in {2}. {3}' Let's also add timestamps in this method. http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@1606 PS1, Line 1606: print('Caught exception {0}, type={1}'.format(str(e), type(e)), file=sys.stderr) This also needs a timestamp. http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1109 PS1, Line 1109: print("%s: %s, %s" % : (self.ERROR_CONNECTING_MESSAGE, type(e).__name__, e), file=sys.stderr) Please also add timestamp for this. We've seen errors like Error connecting: DisconnectedException, Error communicating with impalad: TSocket read 0 bytes It'd be nice to see when the connection fails. http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1460 PS1, Line 1460: nit: redudant space -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 22 May 2024 02:39:16 +0000 Gerrit-HasComments: Yes
