Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21426 )

Change subject: IMPALA-12216: Print timestamp for impala-shell errors
......................................................................


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615
PS4, Line 1615: def log_exception_with_timestamp(e,msg="Exception"):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615
PS4, Line 1615: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1620
PS4, Line 1620: def log_timestamp(msg="Exception"):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1622
PS4, Line 1622:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1461
PS4, Line 1461: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1473
PS4, Line 1473: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1505
PS4, Line 1505: ,
flake8: E231 missing whitespace after ','



--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Saurabh Katiyal <saurabhkati...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 07:26:44 +0000
Gerrit-HasComments: Yes

Reply via email to