Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1464 PS1, Line 1464: (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime()) It would be nice to move some of this to utility functions to make the code less noisy. One idea is to create function like nowstr() that gets the localtime and does the formatting. A function log_error(msg, ex) could be also created to avoid all boilerplate code, so it could be called like log_error("Exception", ex) http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1496 PS1, Line 1496: print ("Exception at: %s" % (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime()))) file=sys.stderr is missing for some reason -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 22 May 2024 13:13:49 +0000 Gerrit-HasComments: Yes
