Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py@1623 PS6, Line 1623: print(msg + " at: %s" % (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime())), Can we put the timestamp at the beginning? So the format is more like a log and we can wrap the code of log_timestamp("Warning") print("Warning: close session RPC failed: {0}, {1}".format(str(e), type(e))) into log_timestamp("Warning: close session RPC failed: {0}, {1}".format(str(e), type(e))) -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 6 Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Comment-Date: Mon, 17 Jun 2024 11:25:27 +0000 Gerrit-HasComments: Yes
