Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21455/5/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/5/be/src/exec/hash-table.cc@376 PS5, Line 376: * sample_size; If I understand correctly than capacity_ can be 1 or N*64. Isn't it possible that the first jump (1-64) is too high in some cases, e.g. if the capacity would be 16 with the original calculation (16KB expr_values_bytes_per_row_)? -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Jun 2024 15:26:32 +0000 Gerrit-HasComments: Yes
