Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21455 )

Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21455/7/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/21455/7/tests/common/test_dimensions.py@119
PS7, Line 119:
> the create...dimension functions below could be shorter by calling this fun
Done


http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py
File tests/query_test/test_join_queries.py:

http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py@218
PS7, Line 218:
> With parquet_none, the catalog_sales table is not partitioned, and the mini
Done



--
To view, visit http://gerrit.cloudera.org:8080/21455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0
Gerrit-Change-Number: 21455
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2024 18:48:17 +0000
Gerrit-HasComments: Yes

Reply via email to