Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21455/7/tests/query_test/test_join_queries.py@218 PS7, Line 218: parquet/snap/bloc > Is there a reason for using this instead of default parquet/none? With parquet_none, the catalog_sales table is not partitioned, and the minimum MEM_LIMIT to pass admission control is 183mb. That is high enough for this test to pass with and without the improvement code. Meanwhile, in tpcds_partitioned_snap_block, both store_sales and catalog_sales are partitioned, allowing query to pass admission control with lower 149mb MEM_LIMIT. However, without the improvement code, it will fail execution in backend due to memory limit exceeded. https://issues.apache.org/jira/browse/IMPALA-13075?focusedCommentId=17848720&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17848720 I will mention this in test comment. -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Jun 2024 18:16:46 +0000 Gerrit-HasComments: Yes
