Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22496 )
Change subject: IMPALA-13074: WRITE TO HDFS node is omitted from Web UI graphic plan ...................................................................... Patch Set 6: (3 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/22496/6/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22496/6/be/src/service/impala-http-handler.cc@1146 PS6, Line 1146: -1 nit: Instead of using a magic constant, we could define constexpr int SINK_ID = -1; somewhere, maybe at the beginning of the enclosing unnamed namespace. http://gerrit.cloudera.org:8080/#/c/22496/6/be/src/service/impala-http-handler.cc@1186 PS6, Line 1186: void PlanToJson(const vector<TPlanFragment>& fragments, const TExecSummary& summary, It would be nice to have unit tests for this function. It's not necessary to add the tests in this CR, but could you please create a Jira ticket about his? http://gerrit.cloudera.org:8080/#/c/22496/6/be/src/service/impala-http-handler.cc@1209 PS6, Line 1209: fragment.output_sink.__isset.table_sink Currently it is not working for UPDATE and MERGE statements when the target table is an Iceberg table, as in those cases fragment.output_sink.__isset.child_data_sinks is true. -- To view, visit http://gerrit.cloudera.org:8080/22496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bd442f6499efde7406d87c2b1fd1b46a45381b Gerrit-Change-Number: 22496 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 14:41:01 +0000 Gerrit-HasComments: Yes
