Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23884 )
Change subject: IMPALA-14673 impala-shell: profile format argument ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py@916 PS4, Line 916: self.__dict__[handle[1]] = impala_shell_defaults[handle[1]] : return True : except KeyError: > With the shell option it seems clearer to me to add format as a parameter i Done http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py@1255 PS4, Line 1255: print(query_profile_prefix + profile, file=out_file) : if faile > This is related to error handling, specifically with invalid input format f With profile_format now being passed as an argument to client's get_runtime_profile, this comment is no longer relevant. -- To view, visit http://gerrit.cloudera.org:8080/23884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I032a5d0436f123d737d46d0b8cecbae09888a789 Gerrit-Change-Number: 23884 Gerrit-PatchSet: 5 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 10:36:12 +0000 Gerrit-HasComments: Yes
