Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 1: (1 comment) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1114 PS1, Line 1114: Expression icebergExpr = converter.convert(expr); : impalaIcebergPredicateMapping_.put(icebergExpr, expr); : boolean wasRelaxed = converter.lastConversionWasRelaxed(); : LOG.debug("Push down the predicate: {} to iceberg (relaxed={})", : icebergExpr, wasRelaxed); : : // If the predicate was relaxed, we must keep the original predicate : // for evaluation by Impala on the pruned data : if (wasRelaxed) { : relaxedExpressions_.add(expr); : } I'd argue for changing the return value of IcebergPredicateConverter.convert() because the current change is dangerous. We use IcebergPredicateConverter.convert() at the following places as well: * AlterTableDropPartitionStmt * ShowFilesStmt These callsites were not modified so if a user issues the following statement: ALTER TABLE ice_t DROP PARTITION s LIKE 'd%d'; It will drop all partitions starting with 'd' which was not the intent of the caller. We should make APIs as secure as possible, that are hard to use incorrectly. Please also add tests for DROP PARTITION and SHOW FILES as well. -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 15:27:06 +0000 Gerrit-HasComments: Yes
