Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1114 PS1, Line 1114: Expression icebergExpr = converter.convert(expr); : impalaIcebergPredicateMapping_.put(icebergExpr, expr); : boolean wasRelaxed = converter.lastConversionWasRelaxed(); : LOG.debug("Push down the predicate: {} to iceberg (relaxed={})", : icebergExpr, wasRelaxed); : : // If the predicate was relaxed, we must keep the original predicate : // for evaluation by Impala on the pruned data : if (wasRelaxed) { : relaxedExpressions_.add(expr); : } > I'd argue for changing the return value of IcebergPredicateConverter.conver 1. Would creating a new class ConverterResult here like you advised earlier be good? public static class ConverterResult { private final Expression icebergExpression; private final boolean isRelaxed; } 2. We'll need to change the return types of all convert() methods for all predicate types. 3. We can modify ShowStatsStmt.java, ShowFilesStmt.java, AlterTableDropPartitionStmt.java to throw exceptions when IcebergPredicateConverter.ConverterResult result = converter.convert(expr); if (result.isRelaxed()) { throw new AnalysisException() } 4. This'll add a new functionality where ALTER TABLE DROP and SHOW FILES will get the support of LIKE predicates with simple patterns like 'test%'. Does this sound good? -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 18:21:45 +0000 Gerrit-HasComments: Yes
