Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1114 PS1, Line 1114: Expression icebergExpr = converter.convert(expr); : impalaIcebergPredicateMapping_.put(icebergExpr, expr); : boolean wasRelaxed = converter.lastConversionWasRelaxed(); : LOG.debug("Push down the predicate: {} to iceberg (relaxed={})", : icebergExpr, wasRelaxed); : : // If the predicate was relaxed, we must keep the original predicate : // for evaluation by Impala on the pruned data : if (wasRelaxed) { : relaxedExpressions_.add(expr); : } > 1. Would creating a new class ConverterResult here like you advised earlier 1. Yeah, a new ConverterResult class make sense. Alternatively you can use a Pair<Expression, ConverterResultEnum>. If you choose ConverterResult, instead of the flag 'isRelaxed' we should still rather have an enum, e.g.: enum ConverterResultEnum { FULLY_CONVERTED, PARTIALLY_CONVERTED, FAILED } 2. Yes. The FAILED status could be used instead of the current exception-based logic, I think the code will be cleaner overall. 3. Yes, it's a good idea. The error message should be clear, e.g. "Given predicate {} cannot be fully converted to Iceberg predicates..." 4. Part 1 already added these functionalities, right? We just didn't test them. Sounds good, thanks for doing these changes! -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 10:47:19 +0000 Gerrit-HasComments: Yes
