Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 )
Change subject: IMPALA-7215: Implement a templatized CountingBarrier ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10827/1/be/src/util/counting-barrier.h File be/src/util/counting-barrier.h: http://gerrit.cloudera.org:8080/#/c/10827/1/be/src/util/counting-barrier.h@39 PS1, Line 39: ; > rather than have a default_promise_value_, why not just pass it as a parame Done http://gerrit.cloudera.org:8080/#/c/10827/1/be/src/util/counting-barrier.h@46 PS1, Line 46: eturn; // count_ can legitimately drop below 0 : if (count_.CompareAndSwap(value, 0)) { : promise_.Set(promise_value); > this would be simpler if we just require the promise value for the non-bool Good point. I implemented a TypedCountingBarrier<T> and made CountingBarrier a user of TypedCountingBarrier<T>. -- To view, visit http://gerrit.cloudera.org:8080/10827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e Gerrit-Change-Number: 10827 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 02:49:04 +0000 Gerrit-HasComments: Yes
