Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 )
Change subject: IMPALA-7215: Implement a templatized CountingBarrier ...................................................................... Patch Set 5: Code-Review+2 (4 comments) Thanks for the review! Rebase, carry +2. http://gerrit.cloudera.org:8080/#/c/10827/4/be/src/util/counting-barrier.h File be/src/util/counting-barrier.h: http://gerrit.cloudera.org:8080/#/c/10827/4/be/src/util/counting-barrier.h@36 PS4, Line 36: ks Wait() with > Not clear which "returned value" this is talking about - sounds like Notify Done http://gerrit.cloudera.org:8080/#/c/10827/4/be/src/util/counting-barrier.h@43 PS4, Line 43: : /// Sets the number of pending notificatio > that's clearer. you could say it this way for Notify() comment. Done http://gerrit.cloudera.org:8080/#/c/10827/4/be/src/util/counting-barrier.h@56 PS4, Line 56: > public comments shouldn't talk about private fields (the client of this cla Done http://gerrit.cloudera.org:8080/#/c/10827/4/be/src/util/counting-barrier.h@61 PS4, Line 61: ms' passes, in which : /// case '*timed_out' will be true. If > same Done -- To view, visit http://gerrit.cloudera.org:8080/10827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e Gerrit-Change-Number: 10827 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 17:49:30 +0000 Gerrit-HasComments: Yes
