Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10827 )
Change subject: IMPALA-7215: Implement a templatized CountingBarrier ...................................................................... IMPALA-7215: Implement a templatized CountingBarrier Currently, our CountingBarrier util only notifies a 'bool' value and uses an underlying Promise<bool>. We're seeing cases in code where we might want to be notified of a different kind of Promise (other than bool). We add a templatized class TypedCountingBarrier<T> and convert CountingBarrier to use the TypedCountingBarrier<T> internally. This was identified while working on IMPALA-7163. Testing: Ran 'core' tests. Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e Reviewed-on: http://gerrit.cloudera.org:8080/10827 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/hdfs-scan-node.cc M be/src/rpc/rpc-mgr-test.cc M be/src/runtime/coordinator.cc M be/src/util/counting-barrier.h M be/src/util/hdfs-bulk-ops.cc 5 files changed, 62 insertions(+), 25 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e Gerrit-Change-Number: 10827 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
