Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 )
Change subject: IMPALA-7215: Implement a templatized CountingBarrier ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h File be/src/util/counting-barrier.h: http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@34 PS3, Line 34: /// Sends one notification, decrementing the number of pending notifications by one. Add something like: If this is the final notifier, sets the value returned to the waiter to 'promise_value' http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@36 PS3, Line 36: int32_t looks like no caller actually uses this return value and so you've annotated them with discard_result(). You could also just make this return void since no one wants the value. I'm fine either way. http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@42 PS3, Line 42: /// Sets the number of pending notifications to 0 and unblocks Wait(). similarly, add comment about 'promise_value' http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@54 PS3, Line 54: /// Blocks until all notifications are received. comment the return value http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@55 PS3, Line 55: T would be good to return "const T&" here and below (to match Promise.Get()) http://gerrit.cloudera.org:8080/#/c/10827/3/be/src/util/counting-barrier.h@58 PS3, Line 58: /// case '*timed_out' will be true. comment return value -- To view, visit http://gerrit.cloudera.org:8080/10827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e Gerrit-Change-Number: 10827 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 04:32:41 +0000 Gerrit-HasComments: Yes
