Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24976 )
Change subject: IMPALA-15463: Use Kudu live row count stats ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24976/8/testdata/workloads/functional-query/queries/QueryTest/kudu_stats.test File testdata/workloads/functional-query/queries/QueryTest/kudu_stats.test: http://gerrit.cloudera.org:8080/#/c/24976/8/testdata/workloads/functional-query/queries/QueryTest/kudu_stats.test@27 PS8, Line 27: ---- RESULTS: RETRY=10 Can we go simply by a higher wait that comfortable for our test machines? I know this is well knows problem for a lot of flaky tests, but I still feel that it's better to go with a simple sleep instead of retrying the assert. http://gerrit.cloudera.org:8080/#/c/24976/8/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/24976/8/tests/common/impala_test_suite.py@1086 PS8, Line 1086: remaining = test_section['RETRY'] if 'RETRY' in test_section else 1 I think this opens Pandora's box, this will be an easy way out for a lot of active waiting/no clear wait signal tests. I fear that it might get abused. How exactly the timing of this wait will happen? Currently, this is an active wait without any sleep. Also, it might worth a separate change. -- To view, visit http://gerrit.cloudera.org:8080/24976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17d806fa9f849bb66fac5dfb500f83fc6d115b58 Gerrit-Change-Number: 24976 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 22:27:46 +0000 Gerrit-HasComments: Yes
