Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh File bin/clean.sh: http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh@81 PS1, Line 81: rm -rf ${IMPALA_HOME}/toolchain We need to be careful here, because I think it is useful to be able to develop Impala without a fast network connection (or even without a network connection). A clean build is often the safest way to switch between different build options (i.e. debug to clang tidy to asan, etc). On my machine (with an excellent internet connection), removing the toolchain and doing mvn -U adds about a minute to a clean rebuild (going from 1:50 to about 3:10). We'll have to decide whether that is a problem. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 18:06:08 +0000 Gerrit-HasComments: Yes
